fix(setup): make resume.py correct from any working directory - #184
Open
jclarkfolklore wants to merge 1 commit into
Open
fix(setup): make resume.py correct from any working directory#184jclarkfolklore wants to merge 1 commit into
jclarkfolklore wants to merge 1 commit into
Conversation
`conductor-setup` SKILL.md instructs `python3 scripts/resume.py`, but the script
resolves `conductor/` relative to the current working directory. No single
working directory satisfies both:
# from a project root — the script is not there
$ python3 scripts/resume.py
can't open file '.../scripts/resume.py': [Errno 2] No such file or directory
# from the skill directory — the script runs, but reports on the skill
# directory rather than on the project
$ cd skills/conductor-setup && python3 scripts/resume.py
{"setup_complete": false, ...}
In practice this is invisible, because the agent self-corrects under the skill's
own "attempt to self-correct once" clause and finds a path that works. The cost
is that the resumption check is non-deterministic: which directory it reports on
depends on how the model chose to resolve the path.
`determine_resumption()` now accepts the project root as `argv[1]`, defaulting to
`os.getcwd()` so existing callers are unaffected, and SKILL.md passes it
explicitly with a note that a bare relative path cannot work.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup skill instructs
python3 scripts/resume.py, but the script resolvesconductor/relative to the current working directory. No single working directory satisfies both.Reproduce
From a project root — the script is not there:
From the skill directory — the script runs, but reports on the skill directory rather than on the project:
Why this is easy to miss
In practice the agent recovers, because
SKILL.md§1.2 tells it to "attempt to self-correct once" — so it finds a path that works and setup proceeds. Nothing appears broken.The cost is that the resumption check is non-deterministic: which directory it reports on depends on how the model happened to resolve the path. A run that self-corrects toward the skill directory will report
setup_complete: falsefor a project that is in fact already initialized, and §1.2 branches on exactly that value.The change
determine_resumption()accepts the project root asargv[1], defaulting toos.getcwd()— so existing callers are unaffected.SKILL.mdpasses it explicitly and notes that a bare relative path cannot work.Two files, +10/-2. No other behaviour changes.
Found while building on Conductor; the fix is upstreamed rather than carried privately, since it is a defect rather than a preference.