Skip to content

Fix websockets 14 retrocompat#2

Open
fviard wants to merge 2 commits intomainfrom
fix-websockets-14-retrocompat
Open

Fix websockets 14 retrocompat#2
fviard wants to merge 2 commits intomainfrom
fix-websockets-14-retrocompat

Conversation

@fviard
Copy link
Owner

@fviard fviard commented Jan 27, 2025

Proposed changes

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@fviard fviard force-pushed the fix-websockets-14-retrocompat branch from 6ecbe4a to 43c0619 Compare January 28, 2025 00:37
…tibility

Python websockets did a breaking change with version 14.
"extra_headers" was renamed to "additionnal_headers".
@fviard fviard force-pushed the fix-websockets-14-retrocompat branch from 43c0619 to 14ad591 Compare January 28, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant