@dobesv Ok, let us know when you have reviewed and updated the PR.

@dobesv You might have figured this out, but you can set the attributes in the manifest by editing the core/build.gradle file and adding:

jar {
    manifest {
        attributes("attribute1": "attribute1 value", "attribute2": "attribute2 value")
    }
}

How does Eclipse use the manifest file for a library?

Yes, I did see that. But on further reflection I realized that if I am
working with the project in eclipse I actually want the MANIFEST.MF to be a
static file so that eclipse can use it.

I have convinced gradle to build an OSGI jar file and also output a
MANIFEST.MF for eclipse to use. I'll sit on it a little longer, though, to
think about possible repurcussions. Do you think it's a problem if
functionaljava is always built as an OSGI jar? AFAIK you can use them as
normal jar files.

On Fri, Jan 9, 2015 at 7:01 PM, Mark Perry notifications@github.com wrote:

You might have figured this out, but you can set the attributes in the
manifest by editing the core/build.gradle file and adding this:

manifest {
attributes("attribute1": "attribute1 value", "attribute2": "attribute2
value")
}
}

—
Reply to this email directly or view it on GitHub
https://github.com/functionaljava/functionaljava/pull/72#issuecomment-69435763
.

I haven't used Eclipse for more than 3 years, can you explain why you want to use projects as plugins in Eclipse? A quick Google search wasn't helpful.

I am using it in an eclipse plugin, so converting the jar to an eclipse
plugin seemed to make it easier to get on the class path of my plugin.

I can probably maintain this as a little fork of my own indefinitely. I'm
not sure it will ever be of use to anyone else.
On Jan 14, 2015 8:07 PM, "Mark Perry" notifications@github.com wrote:

I haven't used Eclipse for more than 3 years, can you explain why you want
to use projects as plugins in Eclipse? A quick Google search wasn't helpful.

—
Reply to this email directly or view it on GitHub
#72 (comment)
.

I spent 10 minutes reading around and it looks like the extra info in the manifest required for an OSGI bundle is ignored in most applications. I think generating the info from the Gradle build is feasible.

Yes, I have this working locally now, I think it will work fine in and out
of eclipse.

One hiccup I ran into is that the OSGI plugin for gradle doesn't like the
tests project because it doesn't create the folder to contain the main
class files. Do we actually need to build and distribute jar files for the
tests? I added a workaround to create the missing folder first, which
works, but I wonder if I could disable building jar files for the tests
altogether.
On Jan 15, 2015 4:40 AM, "Mark Perry" notifications@github.com wrote:

I spent 10 minutes reading around and it looks like the extra info in the
manifest required for an OSGI bundle is ignored in most applications. I
think generating the info from the Gradle build is feasible.

—
Reply to this email directly or view it on GitHub
#72 (comment)
.

The tests project is separate because of the various different support for Scala in IDEs. Putting them in a separate Gradle module allows us to exclude that module temporarily (if necessary).

We don't need to build the jar, just to run the tests.

So where do we go from here?

Hi Mark,

Sorry I have been a bit slow on my PR updates, I've just been a bit busy
work other things. I think I will make the changes to generate an OSGI
compatible jar for the projects except tests, plus generate a MANIFEST.MF
if you run the eclipse target, and update the PR with those changes for
review.
On Jan 23, 2015 3:36 AM, "Mark Perry" notifications@github.com wrote:

So where do we go from here?

—
Reply to this email directly or view it on GitHub
#72 (comment)
.

OK so I updated it so that it builds an OSGI jar for each subproject except tests. Hopefully this doesn't interfere with anyone else's needs. Take a look and tell me what you think.

FYI, I probably won't get to looking at this until the weekend.

I think this is ok, everyone else will just see a more detailed manifest in their jar where the keys will be ignored.