Skip to content

Conversation

@drewctaylor
Copy link
Contributor

Adds fj.data.Option.sequence*, fj.data.Option.traverse*, with the exception of sequencePromise and traversePromise; I don't understand those well enough to test them.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #404 into series/4.x will increase coverage by 0.53%.
The diff coverage is 98.07%.

Impacted file tree graph

@@               Coverage Diff                @@
##             series/4.x     #404      +/-   ##
================================================
+ Coverage         49.03%   49.56%   +0.53%     
- Complexity         2325     2382      +57     
================================================
  Files               153      153              
  Lines              9100     9141      +41     
  Branches            478      478              
================================================
+ Hits               4462     4531      +69     
+ Misses             4491     4459      -32     
- Partials            147      151       +4     
Impacted Files Coverage Δ Complexity Δ
core/src/main/java/fj/data/Option.java 76.87% <98.07%> (+29.81%) 114.00 <38.00> (+55.00)
core/src/main/java/fj/data/List.java 62.92% <0.00%> (-0.46%) 133.00% <0.00%> (-2.00%)
core/src/main/java/fj/data/IOFunctions.java 62.96% <0.00%> (+1.23%) 34.00% <0.00%> (+2.00%)
core/src/main/java/fj/Ord.java 55.30% <0.00%> (+1.51%) 39.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848e2c0...fc85ee1. Read the comment docs.

@drewctaylor drewctaylor force-pushed the functionaljava-403-option branch from 54e2273 to f9ec6ee Compare July 24, 2020 14:31
…n.traverse.*; add sequenceEither, traverseEither as aliases for sequenceEitherRight, sequenceEitherLeft.
@drewctaylor drewctaylor reopened this Jul 24, 2020
@tonymorris tonymorris merged commit 443565b into functionaljava:series/4.x Jul 25, 2020
@drewctaylor drewctaylor deleted the functionaljava-403-option branch July 25, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants