#371: fixed failing property test #373
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## series/5.x #373 +/- ##
================================================
+ Coverage 48.31% 48.33% +0.02%
- Complexity 2253 2254 +1
================================================
Files 153 153
Lines 9094 9094
Branches 490 490
================================================
+ Hits 4394 4396 +2
+ Misses 4552 4550 -2
Partials 148 148
Continue to review full report at Codecov.
|
jbgi
self-requested a review
October 25, 2018 16:35
jbgi
approved these changes
Oct 25, 2018
jbgi
left a comment
jbgi
left a comment
Member
There was a problem hiding this comment.
I see, so hopefully the bug was not in the implementation but in the test.
Thanks for the investigation and fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.