Skip to content

Fix regression in lifted semigroup sum. Fix #365#366

Merged
jbgi merged 1 commit into
functionaljava:series/5.xfrom
jbgi:fixes/365-option-monoid
Oct 7, 2018
Merged

Fix regression in lifted semigroup sum. Fix #365#366
jbgi merged 1 commit into
functionaljava:series/5.xfrom
jbgi:fixes/365-option-monoid

Conversation

@jbgi

@jbgi jbgi commented Oct 7, 2018

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #366 into series/5.x will increase coverage by 0.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@              Coverage Diff               @@
##           series/5.x     #366      +/-   ##
==============================================
+ Coverage       48.44%   48.51%   +0.06%     
==============================================
  Files             175      175              
  Lines            9231     9231              
  Branches          536      536              
==============================================
+ Hits             4472     4478       +6     
+ Misses           4576     4567       -9     
- Partials          183      186       +3
Impacted Files Coverage Δ
core/src/main/java/fj/Semigroup.java 63.88% <100%> (+5.11%) ⬆️
core/src/main/java/fj/Monoid.java 45.32% <66.66%> (+1.15%) ⬆️
core/src/main/java/fj/data/fingertrees/Single.java 81.48% <0%> (-3.71%) ⬇️
core/src/main/java/fj/data/List.java 62.32% <0%> (-0.46%) ⬇️
core/src/main/java/fj/data/Stream.java 68.98% <0%> (-0.35%) ⬇️
core/src/main/java/fj/data/fingertrees/Deep.java 67.58% <0%> (+0.79%) ⬆️
core/src/main/java/fj/data/Option.java 42.37% <0%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1651b...9893314. Read the comment docs.

@jbgi
jbgi merged commit 0820ac0 into functionaljava:series/5.x Oct 7, 2018
@jbgi
jbgi deleted the fixes/365-option-monoid branch October 7, 2018 17:45
@jbgi jbgi added this to the 4.8.1 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants