Add IOFunctions tests #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
============================================
+ Coverage 39.5% 39.74% +0.23%
Complexity 5 5
============================================
Files 178 178
Lines 9265 9265
Branches 527 527
============================================
+ Hits 3660 3682 +22
+ Misses 5454 5430 -24
- Partials 151 153 +2
Continue to review full report at Codecov.
|
jbgi
reviewed
Jul 27, 2018
| ByteArrayOutputStream outContent = new ByteArrayOutputStream(); | ||
| PrintStream originalOut = System.out; | ||
| System.setOut(new PrintStream(outContent)); | ||
| runSafe(io).foreach(s -> runSafe(stdoutPrint(s))); |
Member
There was a problem hiding this comment.
the test is named testSequenceWhile but foreach is what is actually tested?
Contributor
Author
There was a problem hiding this comment.
there is sequenceWhile above. I could split to two tests ...
jbgi
reviewed
Jul 27, 2018
|
|
||
|
|
||
| @Test | ||
| public void testLift() throws IOException { |
Contributor
Author
There was a problem hiding this comment.
just moved this code from the other Test.java I deleted
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gábor Lipták gliptak@gmail.com