use openjdk7, remove oracle installer, try sudo false #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbgi
commented
Jul 21, 2018
jbgi
commented
- Travis does not support oraclejdk7 anymore.
- Oracle-java8-installer may not be necessary (recent enough jdk already provided) and slow down the build.
- Using docker container should also speed up the build.
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
============================================
+ Coverage 39.41% 39.48% +0.06%
Complexity 5 5
============================================
Files 178 178
Lines 9245 9245
Branches 523 523
============================================
+ Hits 3644 3650 +6
+ Misses 5449 5445 -4
+ Partials 152 150 -2
Continue to review full report at Codecov.
|
Contributor
|
@jbgi Yes, the change decreases build time by ~40% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.