Skip to content

Build against java 1.7 and publish artifacts targetting java 1.8 (suffixed by "_1.8") #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mperry merged 4 commits into from
Mar 16, 2017
Merged

Build against java 1.7 and publish artifacts targetting java 1.8 (suffixed by "_1.8") #302

mperry merged 4 commits into from
Mar 16, 2017

Conversation

@jbgi
Copy link
Member

@jbgi jbgi commented Oct 23, 2016 •
edited
Loading

Intended to implement #265.
Also only backport to Java7.
Also updated gradle wrapper to 3.4 and some other versions (retrolambda plugin and scalacheck).

@jbgi jbgi added this to the v4.7 milestone Oct 23, 2016
@jbgi jbgi changed the title Use Java8 classifier when to using retrolambda. Use Java8 classifier for jar build with retrolambda. Oct 23, 2016
@jbgi jbgi changed the title Use Java8 classifier for jar build with retrolambda. Use Java8 classifier when retrolambda is disabled Oct 23, 2016
@jbgi jbgi changed the title Use Java8 classifier when retrolambda is disabled Use java8 classifier when retrolambda is disabled Oct 23, 2016
@jbgi jbgi force-pushed the gradle-java8-classifier branch from ce4e245 to 406d1ad Compare November 6, 2016 14:45
@jbgi jbgi changed the title Use java8 classifier when retrolambda is disabled add "_1.8" suffix to artifact cross-built for java 8, allowing to publish them Nov 6, 2016
@jbgi jbgi changed the title add "_1.8" suffix to artifact cross-built for java 8, allowing to publish them add "_1.8" suffix to artifacts cross-built for java 8, allowing to publish them Nov 6, 2016
@jbgi jbgi changed the title add "_1.8" suffix to artifacts cross-built for java 8, allowing to publish them Build against java 1.7 and publish artifacts targetting java 1.8 (suffixed by "_1.8") Nov 6, 2016
@gliptak gliptak mentioned this pull request Jan 3, 2017
Closed
@jbgi jbgi force-pushed the gradle-java8-classifier branch from 406d1ad to d1b15e1 Compare February 27, 2017 20:31
@codecov-io
Copy link

codecov-io commented Feb 27, 2017

Codecov Report

Merging #302 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage    38.7%   38.74%   +0.03%     
==========================================
  Files         174      174              
  Lines        9176     9176              
  Branches      492      492              
==========================================
+ Hits         3552     3555       +3     
+ Misses       5496     5494       -2     
+ Partials      128      127       -1
Impacted Files Coverage Δ
core/src/main/java/fj/data/Stream.java 53.12% <0%> (+0.34%) ✅
core/src/main/java/fj/data/fingertrees/Deep.java 66.79% <0%> (+0.79%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8451d...d1b15e1. Read the comment docs.

@mperry mperry merged commit 68e8a73 into functionaljava:master Mar 16, 2017
@gliptak gliptak mentioned this pull request Mar 17, 2017
Closed
@jbgi jbgi deleted the gradle-java8-classifier branch October 7, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.7

Development

Successfully merging this pull request may close these issues.

3 participants

@jbgi @codecov-io @mperry