Add a priority queue based on finger trees #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… max for pqueue's
Contributor
Author
core/src/main/java/fj/data/List.java
Outdated
| final A y = ys.head(); | ||
|
|
||
| if (o.isLessThan(x, y)) { | ||
| if (o.isLessThan(x, y) || o.eq(x, y)) { |
Member
There was a problem hiding this comment.
Adding a isLessThanOrEqualTo to Ord would be useful to avoid doing the comparison twice.
Contributor
Author
There was a problem hiding this comment.
Agreed. I have pushed this change.
| Stream<Integer> s = ft.toStream(); | ||
| System.out.println(s.toList()); | ||
|
|
||
| out.println(midPriorityQueue()); |
Member
There was a problem hiding this comment.
missing asserts?
(same for split)
Also commented code and println calls should probably be removed.
Contributor
Author
There was a problem hiding this comment.
I was playing with the code to understand what was happening. Removed.
Member
also improved isLessThanOrEqualTo and simplified Ord instances of Comparable types.
+ some other minor refactoring.
Improvements for functionaljava/functionaljava#279
Contributor
Author
|
I have merged these and addressed each of these issues. Do you think it is ready to merge into the Functional Java master branch? I am too close to the code now and find it hard to spot the errors/improvements. |
Member
|
@mperry yep, look good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.