Implemented Equal, Hash, Arbitrary, and Shrink for Natural as well as… #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the equals, hashCode and toString methods on Natural. Also fixed the subtract method on Natural as well as the Javadoc on the Natural Semigroup for addition.
|
|
||
| @Override | ||
| public boolean equals(final Object that) { | ||
| return Equal.equals0(Natural.class, this, that, Equal.equal(l -> r -> l.value.equals(r.value))); |
Member
There was a problem hiding this comment.
last argument should be Equal.naturalEqual
Contributor
|
I propose we merge this and then fix the shrinkBigInteger (#276) and improve the gen and shrink for natural in another issue (that is not yet created). |
Member
|
merged with 09b6713 with some minor cleanup (use of contramap, added missing final modifier) |
Member
|
@bakeemawaytoys you might want to associate the email address used for the commit (johnson.1922@osu.edu) with your github account, so that the commit is linked to your account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the equals, hashCode and toString methods on Natural. Also fixed the subtract method on Natural as well as the Javadoc on the Natural Semigroup for addition.