Add DB.db method with Try1 #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I only changed one of the call to |
| DbUtils.closeQuietly(s); | ||
| } | ||
| return Unit.unit(); | ||
| DB<Unit> setup = DB.db((Try1<Connection, Unit, SQLException>) t -> { |
Contributor
There was a problem hiding this comment.
c instead of t here for Connection?
|
|
||
| DB<Option<Integer>> query = new DB<Option<Integer>>() { | ||
| @Override | ||
| public Option<Integer> run(Connection c) throws SQLException { |
Contributor
There was a problem hiding this comment.
@gliptak You might want to do this method here while you are at it. I will merge and you can raise another PR if you make the change.
Contributor
Author
There was a problem hiding this comment.
@mperry I specifically left this unchanged, as it takes a different path in the codebase (as additional coverage) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#266