Hard memo memory reduction #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dereferences the computation allowing it to become garbage collected once the value has been memorised.
|
|
||
| static class Memo<A> extends P1<A> { | ||
| private final P1<A> self; | ||
| private volatile P1<A> self; |
Member
There was a problem hiding this comment.
self need not be volatile because the memory barrier is already done via initialized.
But thinking of it, you could let self be volatile and remove initialized altogether, replacing the !initialized check by self != null. WDYT?
Contributor
Author
There was a problem hiding this comment.
Sounds good to me.
jbgi
pushed a commit
to jbgi/functionaljava
that referenced
this pull request
Jun 15, 2016
* hard memo memory reduction. Dereferences the computation allowing it to become garbage collected once the value has been memorised. * removed initialized
jbgi
pushed a commit
to jbgi/functionaljava
that referenced
this pull request
Jun 19, 2016
* hard memo memory reduction. Dereferences the computation allowing it to become garbage collected once the value has been memorised. * removed initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.