More Semigroup additions #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
puffnfresh
commented
May 16, 2016
puffnfresh
commented
- dual
- min/max
- lift
- sumRight
|
|
||
| /** | ||
| * Sums the given values with right-fold. | ||
| */ |
Member
There was a problem hiding this comment.
what about naming it sumNel? associativity make sumRight and sumLeft equivalent, and thus using foldLeft1 would be more efficient...
Member
There was a problem hiding this comment.
sorry, I did a merge of my branch and you will need to rebase now...
Merged
puffnfresh
force-pushed
the
feature/semigroups
branch
from
4fa4e82 to
ac4ab64
Compare
Member
Author
|
@jbgi rebased and fixed! |
puffnfresh
force-pushed
the
feature/semigroups
branch
from
ac4ab64 to
0386eb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.