Skip to content

Conversation

@gliptak
Copy link
Contributor

@gliptak gliptak commented Feb 14, 2016

No description provided.

@gliptak
Copy link
Contributor Author

gliptak commented May 7, 2016

@mperry Please review. Thanks

public void testBool() {
final Arbitrary<Boolean> arbBooleanR = arbitrary(arbBoolean.gen);
final Property p = property(arbBooleanR, arbBooleanR, (m1, m2) -> bool(m1.equals(m2))
.implies(new BoolTestClass(m1).getBoolean() == new BoolTestClass(m2).getBoolean()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of wrapping the Boolean in a class and getting the boolean back out, rather than a direct m1 == m2 expression?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 33.894% when pulling 0f36236 on gliptak:coverage2 into 3716e73 on functionaljava:master.

@mperry
Copy link
Contributor

mperry commented Jun 4, 2016

Do we need the inner class now? Looks like it is not used.

@gliptak
Copy link
Contributor Author

gliptak commented Jun 4, 2016

corrected

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 33.876% when pulling b943873 on gliptak:coverage2 into 97b767e on functionaljava:master.

@mperry mperry merged commit 7224221 into functionaljava:master Jun 6, 2016
@mperry mperry added the internal label Jul 1, 2016
@mperry mperry added this to the v4.6 milestone Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants