Skip to content

Implemented Validation.partition and arbitrary validations #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mperry merged 1 commit into from
Jul 3, 2015
Merged

Implemented Validation.partition and arbitrary validations #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/src/main/java/fj/data/Validation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,6 +1287,16 @@ public Validation<NumberFormatException, Short> f(final String s) {
}
};

/**
* Partitions the list into the list of fails and the list of successes
*/
public static <A, B> P2<List<A>, List<B>> partition(List<Validation<A, B>> list) {
return P.p(
list.filter(v -> v.isFail()).map(v -> v.fail()),
list.filter(v -> v.isSuccess()).map(v -> v.success())
);
}

@Override
public String toString() {
return Show.validationShow(Show.<E>anyShow(), Show.<T>anyShow()).showS(this);
Expand Down
33 changes: 33 additions & 0 deletions props-core/src/test/java/fj/data/properties/ValidationProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package fj.data.properties;

import fj.P2;
import fj.data.List;
import fj.data.Validation;
import fj.test.Arbitrary;
import fj.test.Property;
import fj.test.reflect.CheckParams;
import fj.test.runner.PropertyTestRunner;
import org.junit.Assert;
import org.junit.Test;
import org.junit.runner.RunWith;

import static fj.test.Arbitrary.*;

/**
* Created by MarkPerry on 3/07/2015.
*/
@RunWith(PropertyTestRunner.class)
public class ValidationProperties {

public Property partition() {
Arbitrary<List<Validation<String, Integer>>> al = arbList(arbValidation(arbUSASCIIString, arbInteger));
return Property.property(al, list -> {
P2<List<String>, List<Integer>> p = Validation.partition(list);
boolean b1 = p._1().length() + p._2().length() == list.length();
boolean b2 = p._1().map(s -> Validation.<String, Integer>fail(s)).equals(list.filter(v -> v.isFail()));
boolean b3 = p._2().map(s -> Validation.<String, Integer>success(s)).equals(list.filter(v -> v.isSuccess()));
return Property.prop(b1 && b2 && b3);
});
}

}
7 changes: 7 additions & 0 deletions quickcheck/src/main/java/fj/test/Arbitrary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,13 @@ public static <A> Arbitrary<NonEmptyList<A>> arbNonEmptyList(final Arbitrary<A>
return arbitrary(Gen.listOf1(aa.gen).map(list -> NonEmptyList.fromList(list).some()));
}

/**
* Returns an arbitrary Validation for the given arbitrary parameters.
*/
public static <A, B> Arbitrary<Validation<A, B>> arbValidation(final Arbitrary<A> aa, final Arbitrary<B> ab) {
return arbitrary(arbBoolean.gen.bind(bool -> bool ? ab.gen.map(b -> Validation.<A, B>success(b)) : aa.gen.map(a -> Validation.<A, B>fail(a))));
}

/**
* Returns an arbitrary implementation for streams.
*
Expand Down