Split quickcheck property testing into separate module to address #147 #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Everything looks fine. |
Member
|
I think would be more practical if the quickcheck module provides the common Arbitrary instances directly: everyone that use fj would want them. |
Contributor
|
@jbgi What do you mean by "directly"? There are instances for all core classes (arbInteger, arbList, ...) in the Arbitrary class. |
Member
|
oups you are right. |
Member
|
as for naming, maybe 'laws' would be more explicit than 'props'? |
Contributor
|
I'm not sure. There are functor laws, monad laws etc. But are there any laws for List, Seq? Can be the equality |
Member
|
@orionll yes, property is more general than law. |
mperry
added a commit
that referenced
this pull request
Jun 5, 2015
Split quickcheck property testing into separate module to address #147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #147