Preserve ordering function when converting to a TreeMap#110
Merged
Conversation
…n't implement Comparable (i.e. a List)
mperry
added a commit
that referenced
this pull request
Mar 22, 2015
Preserve ordering function when converting to a TreeMap
Contributor
|
Thanks for this @dobesv. Sorry about the delay in merging this. Looking at this it looks like the need to reverse the keys arises from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fj.data.TreeMapwas using the defaultComparatorinstance intoMutableMap(). The biggest problem with this is that the default comparator requires that keys implementComparable, whereasfj.data.TreeMapdoes not require keys to implementComparable. Even when keys do implementComparable, the user may have used a different ordering in theirfj.data.TreeMapwhich can be preserved in the resultingjava.util.TreeMap.