@mperry can you please have a look? please provide feedback.

On my list of todos.

:) thanks

In summary, need to resolve contramap. Thanks for this PR and pushing FunctionalJava forward, it is great to see. In future, do work on a branch (not master) and submit a PR. We don't need the extra noise of additional commits in the PR that I believe is caused by working on master.

@mperry thanks, you will see changes in a branch henceforth.

I think the names are fine as is. Specifically, I think contramap is appropriately named.

Here are some considerations:

• Rename isnot to simply not. I only make this suggestion because it has some precedence, at least in my experience.
• If you leave isnot named as-is, consider adding another method is, which is simply an alias for contramap. Give the users a choice between a preferred name, if it happens to be that way.

In some older Haskell libraries, with use of contravariant functors, the name comap was used (where contramap is used here). This is an inappropriate name, since the prefix co has a strong precedence to mean categorical duality, where no such duality has existed. Since this time, the name contramap has been used as the correction and I have never seen any more appropriate name.

Unlike for invariant (exponential) mapping, where I have seen several different names, for the same type of mapping; xmap, expmap, invmap.

Data.Function.Predicate (http://hackage.haskell.org/package/predicates-0.1/docs/Data-Function-Predicate.html) uses is and isn't, so I suggest we add is as an alias to contramap.

Hi @amarpotghan, why did you close this PR?

@mperry created pull-request #104 to remove commit noise :)