Make instance fields final when possible

jbgi · jbgi · commit 9eaabfafa058 · 2016-05-24T07:39:37.000+02:00
diff --git a/core/src/main/java/fj/control/parallel/Actor.java b/core/src/main/java/fj/control/parallel/Actor.java
@@ -36,14 +36,14 @@ public static <T> Actor<T> queueActor(final Strategy<Unit> s, final Effect1<T> e
     return actor(Strategy.<Unit>seqStrategy(), new Effect1<T>() {
 
       // Lock to ensure the actor only acts on one message at a time
-      AtomicBoolean suspended = new AtomicBoolean(true);
+      final AtomicBoolean suspended = new AtomicBoolean(true);
 
       // Queue to hold pending messages
-      ConcurrentLinkedQueue<T> mbox = new ConcurrentLinkedQueue<T>();
+      final ConcurrentLinkedQueue<T> mbox = new ConcurrentLinkedQueue<T>();
 
       // Product so the actor can use its strategy (to act on messages in other threads,
       // to handle exceptions, etc.)
-      P1<Unit> processor = new P1<Unit>() {
+      final P1<Unit> processor = new P1<Unit>() {
         @Override public Unit _1() {
           // get next item from queue
           T a = mbox.poll();
diff --git a/core/src/main/java/fj/data/IOW.java b/core/src/main/java/fj/data/IOW.java
@@ -10,7 +10,7 @@
  */
 public final class IOW<A> implements IO<A> {
 
-    private IO<A> io;
+    private final IO<A> io;
 
     private IOW(IO<A> in) {
         io = in;
diff --git a/core/src/main/java/fj/data/Reader.java b/core/src/main/java/fj/data/Reader.java
@@ -9,7 +9,7 @@
  */
 public class Reader<A, B> {
 
-	private F<A, B> function;
+	private final F<A, B> function;
 
 	public Reader(F<A, B> f) {
 		function = f;
diff --git a/core/src/main/java/fj/data/State.java b/core/src/main/java/fj/data/State.java
@@ -11,7 +11,7 @@
  */
 public final class State<S, A> {
 
-	private F<S, P2<S, A>> run;
+	private final F<S, P2<S, A>> run;
 
 	private State(F<S, P2<S, A>> f) {
 		run = f;
diff --git a/core/src/main/java/fj/data/Writer.java b/core/src/main/java/fj/data/Writer.java
@@ -7,9 +7,9 @@
  */
 public final class Writer<W, A> {
 
-	private A val;
-	private W logValue;
-    private Monoid<W> monoid;
+	private final A val;
+	private final W logValue;
+	private final Monoid<W> monoid;
 
 	private Writer(A a, W w, Monoid<W> m) {
 		val = a;
