Skip to content

Commit 9d2ca34

Browse files
jbgijbgi
committed
Fix some final modifiers. Add private constructor on utility classes.
1 parent 14b7f5c commit 9d2ca34

29 files changed

+134
-102
lines changed

‎core/src/main/java/fj/Effect.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public static P1<Unit> f(Effect0 e) {
3333
*
3434
* @return The function using the given effect.
3535
*/
36-
public static final <A> F<A, Unit> f(Effect1<A> e1) {
36+
public static <A> F<A, Unit> f(Effect1<A> e1) {
3737
return a -> {
3838
e1.f(a);
3939
return unit();
@@ -95,7 +95,7 @@ public static <A, B, C, D, E> F5<A, B, C, D, E, Unit> f(Effect5<A, B, C, D, E> z
9595
* @param f The function to map over the effect.
9696
* @return An effect after a contra-variant map.
9797
*/
98-
public static final <A, B> Effect1<B> contramap(Effect1<A> e1, final F<B, A> f) {
98+
public static <A, B> Effect1<B> contramap(Effect1<A> e1, final F<B, A> f) {
9999
return b -> e1.f(f.f(b));
100100
}
101101

‎core/src/main/java/fj/F1Functions.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,12 @@
1818
/**
1919
* Created by MarkPerry on 6/04/2014.
2020
*/
21-
public class F1Functions {
21+
public final class F1Functions {
2222

2323

24+
private F1Functions() {
25+
}
26+
2427
/**
2528
* Function composition
2629
*

‎core/src/main/java/fj/F2Functions.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,13 @@
1313
/**
1414
* Created by MarkPerry on 6/04/2014.
1515
*/
16-
public class F2Functions {
16+
public final class F2Functions {
1717

1818

19-
/**
19+
private F2Functions() {
20+
}
21+
22+
/**
2023
* Partial application.
2124
*
2225
* @param a The <code>A</code> to which to apply this function.

‎core/src/main/java/fj/F3Functions.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,13 @@
99
/**
1010
* Created by MarkPerry on 6/04/2014.
1111
*/
12-
public class F3Functions {
12+
public final class F3Functions {
1313

1414

15-
/**
15+
private F3Functions() {
16+
}
17+
18+
/**
1619
* Partial application.
1720
*
1821
* @param a The <code>A</code> to which to apply this function.

‎core/src/main/java/fj/F4Functions.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,12 @@
66
/**
77
* Created by MarkPerry on 6/04/2014.
88
*/
9-
public class F4Functions {
9+
public final class F4Functions {
1010

11-
/**
11+
private F4Functions() {
12+
}
13+
14+
/**
1215
* Partial application.
1316
*
1417
* @param a The <code>A</code> to which to apply this function.

‎core/src/main/java/fj/F5Functions.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
/**
77
* Created by MarkPerry on 6/04/2014.
88
*/
9-
public class F5Functions {
9+
public final class F5Functions {
10+
11+
private F5Functions() {
12+
}
1013

1114
/**
1215
* Partial application.

‎core/src/main/java/fj/F6Functions.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
/**
77
* Created by MarkPerry on 6/04/2014.
88
*/
9-
public class F6Functions {
9+
public final class F6Functions {
10+
11+
private F6Functions() {
12+
}
1013

1114
/**
1215
* Partial application.

‎core/src/main/java/fj/F7Functions.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
/**
77
* Created by MarkPerry on 6/04/2014.
88
*/
9-
public class F7Functions {
9+
public final class F7Functions {
10+
11+
private F7Functions() {
12+
}
1013

1114
/**
1215
* Partial application.

‎core/src/main/java/fj/F8Functions.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
/**
77
* Created by MarkPerry on 6/04/2014.
88
*/
9-
public class F8Functions {
9+
public final class F8Functions {
10+
11+
private F8Functions() {
12+
}
1013

1114
/**
1215
* Partial application.

‎core/src/main/java/fj/Ord.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ public A min(final A a1, final A a2) {
157157
*/
158158
public final F<A, F<A, A>> min = curry((a, a1) -> min(a, a1));
159159

160-
public final Ord<A> reverse() { return ord(Function.flip(f)); }
160+
public Ord<A> reverse() { return ord(Function.flip(f)); }
161161

162162
/**
163163
* Returns an order instance that uses the given equality test and ordering function.

0 commit comments

Comments
 (0)