fix performance and StackOverflowError issue in TreeMap.update()

gregrow · gregrow · commit 62b202f694ed · 2015-01-27T02:51:14.000+01:00
diff --git a/core/src/main/java/fj/data/TreeMap.java b/core/src/main/java/fj/data/TreeMap.java
@@ -216,7 +216,7 @@ public F<K, Option<V>> get() {
    */
   public P2<Boolean, TreeMap<K, V>> update(final K k, final F<V, V> f) {
     final P2<Boolean, Set<P2<K, Option<V>>>> up =
-        tree.update(p(k, Option.<V>none()), P2.<K, Option<V>, Option<V>>map2_(Option.<V, V>map().f(f)));
+        tree.update(p(k, Option.<V>none()), compose(P2.tuple(P.p2()), P2.<K, Option<V>, Option<V>>map2_(Option.<V, V>map().f(f))));
     return P.p(up._1(), new TreeMap<K, V>(up._2()));
   }
 

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ public F<K, Option<V>> get() {`
`216`	`216`	`*/`
`217`	`217`	`public P2<Boolean, TreeMap<K, V>> update(final K k, final F<V, V> f) {`
`218`	`218`	`final P2<Boolean, Set<P2<K, Option<V>>>> up =`
`219`		`- tree.update(p(k, Option.<V>none()), P2.<K, Option<V>, Option<V>>map2_(Option.<V, V>map().f(f)));`
	`219`	`+ tree.update(p(k, Option.<V>none()), compose(P2.tuple(P.p2()), P2.<K, Option<V>, Option<V>>map2_(Option.<V, V>map().f(f))));`
`220`	`220`	`return P.p(up._1(), new TreeMap<K, V>(up._2()));`
`221`	`221`	`}`
`222`	`222`