Skip to content

Commit 5f73cac

Browse files
committed
List.minimum/maximum: use uncurried Ord.max/min for better perf.
1 parent 732a151 commit 5f73cac

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

core/src/main/java/fj/data/List.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1462,7 +1462,7 @@ public static <A> F<List<A>, Integer> length_() {
14621462
* @return The maximum element in this list according to the given ordering.
14631463
*/
14641464
public final A maximum(final Ord<A> o) {
1465-
return foldLeft1(o.max);
1465+
return foldLeft1(o::max);
14661466
}
14671467

14681468
/**
@@ -1472,7 +1472,7 @@ public final A maximum(final Ord<A> o) {
14721472
* @return The minimum element in this list according to the given ordering.
14731473
*/
14741474
public final A minimum(final Ord<A> o) {
1475-
return foldLeft1(o.min);
1475+
return foldLeft1(o::min);
14761476
}
14771477

14781478
public final java.util.List<A> toJavaList() {

demo/src/main/java/fj/demo/euler/Problem4.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ public static void main(final String[] a) {
1919
intShow.println(tdl.tails().bind(tdl.zipWith(multiply)).filter(i -> {
2020
final Stream<Character> s = intShow.show(i);
2121
return streamEqual(charEqual).eq(s.reverse().take(3), s.take(3));
22-
}).foldLeft1(intOrd.max));
22+
}).foldLeft1(intOrd::max));
2323
}
2424
}

0 commit comments

Comments
 (0)