Skip to content

Commit 5f935c9

Browse files
committed
Add parser when there is no error
1 parent f46524f commit 5f935c9

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

api/pkg/services/message_service.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,14 +338,20 @@ func (service *MessageService) SendMessage(ctx context.Context, params MessageSe
338338
}
339339
ctxLogger.Info(fmt.Sprintf("created event [%s] with id [%s] and message id [%s] and user [%s]", event.Type(), event.ID(), eventPayload.MessageID, eventPayload.UserID))
340340

341+
message, err := service.storeSentMessage(ctx, eventPayload)
342+
if err != nil {
343+
msg := fmt.Sprintf("cannot store message with id [%s]", eventPayload.MessageID)
344+
return nil, service.tracer.WrapErrorSpan(span, stacktrace.Propagate(err, msg))
345+
}
346+
341347
timeout := service.getSendDelay(ctxLogger, eventPayload, params.SendAt)
342348
if _, err = service.eventDispatcher.DispatchWithTimeout(ctx, event, timeout); err != nil {
343349
msg := fmt.Sprintf("cannot dispatch event type [%s] and id [%s]", event.Type(), event.ID())
344350
return nil, service.tracer.WrapErrorSpan(span, stacktrace.Propagate(err, msg))
345351
}
346352

347353
ctxLogger.Info(fmt.Sprintf("[%s] event with ID [%s] dispatched succesfully for message [%s] with user [%s] and delay [%s]", event.Type(), event.ID(), eventPayload.MessageID, eventPayload.UserID, timeout))
348-
return service.storeSentMessage(ctx, eventPayload)
354+
return message, err
349355
}
350356

351357
func (service *MessageService) getSendDelay(ctxLogger telemetry.Logger, eventPayload events.MessageAPISentPayload, sendAt *time.Time) time.Duration {

api/pkg/validators/bulk_message_handler_validator.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ func (v *BulkMessageHandlerValidator) parseXlsx(ctxLogger telemetry.Logger, user
151151
})
152152
}
153153

154-
return messages, nil
154+
return messages, url.Values{}
155155
}
156156

157157
func (v *BulkMessageHandlerValidator) convertExcelTime(user *entities.User, value string) (*time.Time, error) {
@@ -206,7 +206,7 @@ func (v *BulkMessageHandlerValidator) parseCSV(ctxLogger telemetry.Logger, user
206206
return nil, result
207207
}
208208

209-
return messages, nil
209+
return messages, url.Values{}
210210
}
211211

212212
func (v *BulkMessageHandlerValidator) validateMessages(messages []*requests.BulkMessage) url.Values {

0 commit comments

Comments
 (0)