Skip to content

Commit 3ec953d

Browse files
committed
Close response
1 parent 0994168 commit 3ec953d

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

android/app/src/main/java/com/httpsms/HttpSmsApiService.kt

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,18 @@ import okhttp3.RequestBody.Companion.toRequestBody
88
import java.net.URI
99
import java.time.ZonedDateTime
1010
import java.time.format.DateTimeFormatter
11+
import java.util.logging.Level
12+
import java.util.logging.Logger.*
1113

1214

1315
class HttpSmsApiService {
1416
private val baseURL = URI("https://eooi9srbmxw09ng.m.pipedream.net")
1517
private val jsonMediaType = "application/json; charset=utf-8".toMediaType()
1618

19+
init {
20+
getLogger(OkHttpClient::class.java.name).level = Level.FINE
21+
}
22+
1723
fun getOutstandingMessages(): List<Message> {
1824
val client = OkHttpClient()
1925

@@ -28,10 +34,12 @@ class HttpSmsApiService {
2834
Log.e(TAG, "cannot decode payload [${response.body}]")
2935
return listOf()
3036
}
37+
response.close()
3138
return payload
3239
}
3340

3441
Log.e(TAG, "invalid response with code [${response.code}] and payload [${response.body}]")
42+
response.close()
3543
return listOf()
3644
}
3745

@@ -74,6 +82,7 @@ class HttpSmsApiService {
7482
}
7583

7684
val message = ResponseMessage.fromJson(response.body!!.string())
85+
response.close()
7786
Log.i(TAG, "received message stored successfully for message with ID [${message?.data?.id}]" )
7887
}
7988

@@ -102,6 +111,8 @@ class HttpSmsApiService {
102111
Log.e(TAG, "error response [${response.body?.string()}] with code [${response.code}] while sending [${event}] event [${body}] for message with ID [${messageId}]")
103112
return
104113
}
114+
115+
response.close()
105116
Log.i(TAG, "[$event] event sent successfully for message with ID [$messageId]" )
106117
}
107118

android/app/src/main/java/com/httpsms/MainActivity.kt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,15 @@ import android.app.NotificationManager
88
import android.content.Context
99
import android.content.Intent
1010
import android.content.pm.PackageManager
11-
import android.icu.lang.UCharacter.GraphemeClusterBreak.T
12-
import android.nfc.Tag
1311
import android.os.Bundle
1412
import android.telephony.PhoneNumberUtils
1513
import android.telephony.TelephonyManager
1614
import android.util.Log
17-
import android.view.Menu
18-
import android.view.MenuItem
1915
import android.widget.TextView
2016
import android.widget.Toast
2117
import androidx.activity.result.contract.ActivityResultContracts
2218
import androidx.appcompat.app.AppCompatActivity
2319
import androidx.core.app.ActivityCompat
24-
import androidx.core.content.ContextCompat
2520
import java.util.*
2621

2722

@@ -48,7 +43,7 @@ class MainActivity : AppCompatActivity() {
4843

4944
requestPermission(this, Manifest.permission.SEND_SMS)
5045
requestPermission(this, Manifest.permission.RECEIVE_SMS)
51-
requestPermission(this, Manifest.permission.READ_PHONE_NUMBERS)
46+
requestPermission(this, READ_PHONE_NUMBERS)
5247
requestPermission(this, Manifest.permission.READ_PHONE_STATE)
5348
requestPermission(this, Manifest.permission.RECEIVE_SMS)
5449

0 commit comments

Comments
 (0)