Skip to content

Commit 1a8f302

Browse files
committed
Simplify the API key parser code
1 parent 0ff8e56 commit 1a8f302

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

api/pkg/middlewares/api_key_auth_middleware.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,7 @@ func APIKeyAuth(logger telemetry.Logger, tracer telemetry.Tracer, userRepository
1919

2020
ctxLogger := tracer.CtxLogger(logger, span)
2121

22-
apiKey := c.Get(authHeaderAPIKey)
23-
if len(apiKey) == 0 {
24-
apiKey = getAPIKeyFromPayload(c)
25-
}
26-
22+
apiKey := getAPIKeyFromRequest(c)
2723
if len(apiKey) == 0 || apiKey == "undefined" {
2824
span.AddEvent(fmt.Sprintf("the request header has no [%s] header", authHeaderAPIKey))
2925
return c.Next()
@@ -40,13 +36,18 @@ func APIKeyAuth(logger telemetry.Logger, tracer telemetry.Tracer, userRepository
4036
}
4137
}
4238

43-
func getAPIKeyFromPayload(c *fiber.Ctx) string {
39+
func getAPIKeyFromRequest(c *fiber.Ctx) string {
40+
apiKey := c.Get(authHeaderAPIKey)
41+
if len(apiKey) != 0 {
42+
return apiKey
43+
}
44+
4445
payload := struct {
4546
APIKey string `json:"x-api-key" form:"x-api-key" query:"x-api-key"`
4647
}{}
4748

48-
if err := c.BodyParser(&payload); err != nil || payload.APIKey == "" {
49-
return ""
49+
if err := c.BodyParser(&payload); err == nil && payload.APIKey != "" {
50+
return payload.APIKey
5051
}
5152

5253
if err := c.QueryParser(&payload); err != nil {

0 commit comments

Comments
 (0)