#172 improvement: Allow Google HOC to be initialized from props#178
Merged
auser merged 9 commits intoApr 7, 2018
Merged
Conversation
…nctions-as-input # Conflicts: # README.md # src/GoogleApiComponent.js
rangoo94
changed the title
Contributor
|
This looks great! Do the examples still work? |
Contributor
Author
|
I just tested it and it had a single warning with |
Contributor
|
Hey there - Does this actually work for you? I tested the new version 2.0.0, changing the language via props. However, the map does not change its language. Do we need to re-initialize something more? |
Contributor
Author
|
Hey @mruoss, I will have time in the evening, so I will check it out deeply. |
Contributor
|
Thanks @rangoo94. I had a quick look but did not have time to dig deeper. I guess the problem is that the ScriptCache does not re-fetch the resources from google after the config changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
It's just improvement for #172, which is also updating input when changes to props may affect component options.