Add React 16 to peerDependencies#173
Conversation
|
All components are not compatible with React 16 ! |
|
I am using all the components except for Polygon and Polyline, which components are you referring to? |
|
Yeah, we’ll have to update the components. Wanna take a stab at it @sonaye? |
|
I took a look at Both look fine to me, unless I am missing something, so I am not sure about what needs to be done here to make things work. Can you explain what's currently lacking @auser and perhaps point me in the right direction? I'll see what I can do. |
|
Note that I've been using the package with React 16 since it was released, never encountered an issue and I don't recall making any changes to the 15 code base to migrate it to 16. |
|
It’s not that they are incompatible, it’s that the code currently used ‘createClass’ vs. classical style |
|
createClass exists only in the examples not the package itself, someone already updated the code. I’ll take care of the examples. https://github.com/fullstackreact/google-maps-react/search?q=createClass |
|
Examples have been updated and tested. Also: I removed |
|
The package in general needs some cleaning, there are tens of devDependencies that are really not needed (the whole process is very outdated), it's very dev unfriendly to be honest. If you are open to receiving another PR that take care of that please let me know. |
This reverts commit 01ad915.
|
@sonaye absolutely! Definitely open |
|
@auser Great, I'll work on it. I reverted removing the dist folder for now. |
|
I just need to test it locally and I’m down to release a new version if all is good |
|
👍 AWESOME! New version released! |
|
I spent a couple of hours trying to refactor the project to make it more dev friendly and optimize it a little bit. I concluded that it's impossible for me to do that without introducing a couple of breaking changes (and possibly make different design decisions that don't match the ones currently implemented). The code while it does the job and works just fine as a final product actually, is in a bad shape, to the extent that it would be easier for me just to start building everything from scratch instead of patching things up. It's best that we keep things as they are I think, as this has been working well for the past couple of years. Thanks for keeping this library maintained. |
|
Things that I didn't understand:
Things to look into:
This isn't a critique in any way, just some feedback. |
I've been using this package with React 16 for a while on multiple projects, it works great. Not sure why it is still not officially supported though, this PR updates the peerDependencies.