Skip to content

Allow GoogleApiWrapper() HOC to be initialized with data from props #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auser merged 3 commits into from
Apr 7, 2018
Merged

Allow GoogleApiWrapper() HOC to be initialized with data from props #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feb9a77
input could be object or function, to be able to pass props
neuzanunes Mar 29, 2018
044aa37
Add the configuration function to the README.
Mar 29, 2018
d869f0a
Merge remote-tracking branch 'upstream/master' into feature/accept-fu…
Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,17 @@ export default GoogleApiWrapper({
})(MapContainer)
```

Alternatively, the `GoogleApiWrapper` Higher-Order component can be configured by passing a function that will be called with whe wrapped component's `props` and should returned the configuration object.

```javascript
export default GoogleApiWrapper(
(props) => ({
apiKey: props.apiKey,
language: props.language,
}
))(MapContainer)
```

If you want to add a loading container _other than the default_ loading container, simply pass it in the HOC, like so:

```javascript
Expand Down
6 changes: 3 additions & 3 deletions src/GoogleApiComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ const defaultCreateCache = options => {

const DefaultLoadingContainer = props => <div>Loading...</div>;

export const wrapper = options => WrappedComponent => {
const createCache = options.createCache || defaultCreateCache;

export const wrapper = input => WrappedComponent => {
class Wrapper extends React.Component {
constructor(props, context) {
super(props, context);
const options = typeof input === 'function' ? input(props) : input;

@rangoo94 rangoo94 Apr 4, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, but I think that it's worth to rebuild it on props change as well. What do you think?

@auser auser Apr 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Wanna add a PR @rangoo94?

@rangoo94 rangoo94 Apr 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I will do it today.

@rangoo94 rangoo94 Apr 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added PR with update: #178

const createCache = options.createCache || defaultCreateCache;

this.scriptCache = createCache(options);
this.scriptCache.google.onLoad(this.onLoad.bind(this));
Expand Down