Repository navigation
Conversation
The scheduler needs MonotonicTimer, which is new in channels v1.13.0. Point the dependency at PR 595 temporarily until v1.13.0 is released, then replace it with >= 1.13.0, < 2. Raise the core floor to 1.6.0 and typing-extensions to 4.16.0, which channels v1.13 requires. Users get these versions through channels anyway, so this adds no new constraint. It lets pytest_min resolve the same requirements when it pins the direct dependency floors. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Use MonotonicTimer for the retry and scheduling timers, including the private annotations. Replace the actor channel's close call with aclose. These replacements keep the existing timing and shutdown behavior while avoiding APIs removed in channels v2. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Document the temporary channels reference and its required core and typing-extensions versions. The channels API migration only changes internal code, so users don't need to change their dispatch calls. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
Bot
added
part:docs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispatch still uses the Timer alias and channel close method that channels v2 removes. I replace them with MonotonicTimer and aclose without changing the public dispatch API or behavior.
The frequenz-channels dependency points at PR 595 temporarily until v1.13.0 is released. After the release, the dependency will change to
>= 1.13.0, < 2. I raise the core and typing-extensions floors to the versions channels requires so pytest_min can resolve them.