Repository navigation
Conversation
Healthy dispatch streams should not reconnect on a timer. Let gRPC keepalive detect dead connections unless the caller requests a finite stream timeout. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
requested review from
ela-kotulska-frequenz and
florian-wagner-frequenz
and removed request for
a team
November 11, 2026 09:47
github-actions
Bot
added
part:docs
Marenz
enabled auto-merge
November 11, 2026 09:49
cwasicki
approved these changes
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispatch streams currently reconnect every five minutes even while healthy because the client applies a default deadline.
Default
stream_timeouttoNoneso gRPC keepalive detects dead connections. Callers can still pass a finite timeout; unary deadlines are unchanged.