Skip to content

Unify/clean up the way to set channel options #124

Open

Description

@llucax

What's needed?

Up until #121, all channel options could be specified via the server URL, as query parameters. Now we have an inconsistency where only the auth key and signing secret can only be passed as default channel options when instantiating the base client.

Proposed solution

The obvious solution is parse the auth key and signing secret from the server URL as other options.

Use cases

No response

Alternatives and workarounds

These being secrets, it might not be the best option, as it is usually to pass secrets as env vars, and passing secrets via the URL will convert the whole URL in a secret, which might not be necessary.

So alternatively we could split secrets as such, and separate them from options. Then we can natively read secrets from env vars too, but maybe that's not even necessary.

Additional context

No response

Activity

  1. added
    part:❓We need to figure out which part is affected
    priority:❓We need to figure out how soon this should be addressed
    type:enhancementNew feature or enhancement visitble to users
    part:codeAffects the code in general
    and removed
    part:❓We need to figure out which part is affected
    priority:❓We need to figure out how soon this should be addressed
    on Apr 3, 2025
  2. added this to the Untriaged milestone on May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    part:codeAffects the code in generaltype:enhancementNew feature or enhancement visitble to users

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions