Skip to content

Conversation

@ArshpreetS
Copy link
Contributor

@ArshpreetS ArshpreetS commented Nov 5, 2025

Checklist:

Closes #63432

Ran the code locally and confirm that the changes are working as expected. I also ran the tests locally and I found no error there as well

Doubt: The css property color: gray is also present in various language challenges which can be found in i18n-curriculum repo. I think I need to raise a similar PR for that repo as well, can you confirm the same and I will raise it as well.

Screenshots ( local testing )

image

for pnpm run test:curriculum:content
image

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Nov 5, 2025
@ilenia-magoni
Copy link
Contributor

think I need to raise a similar PR for that repo as well, can you confirm the same and I will raise it as well.

no, never make changes to the i18n files directly, those are treated separately

@ArshpreetS
Copy link
Contributor Author

ArshpreetS commented Nov 5, 2025

never make changes to the i18n files directly, those are treated separately

Doubt: If we don't make changes to i18n files, won't color: gray will show up when the language is changed in the website?

@ilenia-magoni
Copy link
Contributor

They will be changed, there are workflows for that, you should not change them yourself

@ilenia-magoni ilenia-magoni enabled auto-merge (squash) November 5, 2025 12:26
@ilenia-magoni ilenia-magoni merged commit 67922ff into freeCodeCamp:main Nov 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workshop greeting card uses colors of insufficient contrast

2 participants