Repository navigation
Add ReactiveX documentation - #970
Conversation
|
Looks like you’ve got a merge conflict on Prism.js. |
|
Fixed :) |
| css('h2').each do |node| | ||
| node.inner_html = node.inner_html.gsub('Information:', 'Information') | ||
| end | ||
|
|
There was a problem hiding this comment.
On http://localhost:9292/reactivex/documentation/operators#categorized, the linked code blocks don’t show up properly. This is because the HTML structure is like <a><strong><code>...</code></strong></a>, so the <code> element doesn’t know it’s supposed to inherit its color. This could be fixed either by stripping out the extra <strong>, moving it outside of the <a>, or changing the base DevDocs CSS to match a <code> anywhere inside a <a>. Here’s the offending rule:
devdocs/assets/stylesheets/global/_base.scss
Line 121 in 6efad32
There was a problem hiding this comment.
Looking at this again, the <strong> seems to have some significance in this doc, so going the route of changing the above selector would be better, so as to retain the boldface. However, it seems there’s an additional rule specifying font-weight: normal for code spans, so that needs to be either overridden or removed (if it’s not necessary).
|
Processed your review comments. Regarding the Backpressure Operators page, it is now properly capitalized and categorized under "Manual". |
j-f1
left a comment
There was a problem hiding this comment.
Just the one comment I unresolved, but everything else LGTM.
Co-Authored-By: Jed Fox <git@twopointzero.us>
Add ReactiveX documentation
Added a scraper for the ReactiveX documentation.
The documentation is licensed under the Apache License 2.0.
The official icon is also licensed under the Apache License 2.0. Because I could only find a 32x32 version with a transparent background in the ReactiveX repositories, I used Imagick's
convertto create a 16x16 version of it.Image downloading is disabled because the docs contain a lot of images which makes scraping really, really slow (10+ seconds for some pages), and because enabling it causes 14 pages to be skipped because of an HTTP error. Not sure why that is, but when
options[:download_images]is set tofalse, it works fine.Types:
