Repository navigation
Add MariaDB documentation - #841
Conversation
|
Work in progress: I'll remove the wget usage when I come back from holiday (end of next week). |
Switch to UrlScraper Refactoring
|
@jmerle This looks good! Are you able to fix the image links? On some or all images, the original image links get modified. The first image link is The link should be |
|
Will do that and fix the merge conflict on |
|
Is there anything left to do in order to merge this PR ? |
|
Nope, but it might take a while before it's merged because there are 7 open PR's older than this one and the move of the project to freeCodeCamp is not complete yet (it's getting close though). |
|
Basically, @Thibaut had almost no time to maintain this project and merge PRs like this one, so he handed it off to freeCodeCamp, which will be able to assign at least one engineer (@ahmadabdolsaheb) to work on this more often. |
|
Hey @Thibaut, @ahmadabdolsaheb do you have any ETA on this PR merge? |
|
The latest commit makes the scraper scrape from https://mariadb.com/kb/en/ instead of the old https://kb-mirror.mariadb.com/ since the latter seems to have been taken down. Unfortunately the official website doesn't make it possible to distinguish between MariaDB Server documentation and the other pages in the knowledge base based on url, which is why I used a little workaround to be able to make this decision in a filter where it is possible to make the decision based on content on the page. |
|
I've added the icon you suggested, it looks good. |
|
I believe enough time has passed for this PR and #970 to be reviewed, so I'm merging them despite not having a review approval. |
Add MariaDB documentation
|
Awesome, thanks so much! :D :D :D (btw, is it possible to write a scraper in Node at all? Contributing a scraper sounds cool, but I don't know ruby. |
|
No, scrapers can only be written in Ruby. |
|
That's a shame. Maybe one day I'll learn Ruby then. |

Added a scraper for the MariaDB documentation (Trello card).
The documentation is licensed under the Creative Commons Attribution 3.0 Unported License and the GNU Free Documentation License.
The official logo can't be used because the original proportions must be retained, and those original proportions are not a square.
Types:
