Skip to content

Add MariaDB documentation - #841

Merged
jmerle merged 10 commits into
freeCodeCamp:masterfrom
jmerle:mariadb
Oct 20, 2019
Merged

jmerle merged 10 commits into
freeCodeCamp:masterfrom
jmerle:mariadb

Conversation

@jmerle

@jmerle jmerle commented Jul 15, 2018 •

Copy link
Copy Markdown
Contributor

Added a scraper for the MariaDB documentation (Trello card).

The documentation is licensed under the Creative Commons Attribution 3.0 Unported License and the GNU Free Documentation License.

The official logo can't be used because the original proportions must be retained, and those original proportions are not a square.

Types:

@jmerle

jmerle commented Jul 18, 2018 •

Copy link
Copy Markdown
Contributor Author

Work in progress: I'll remove the wget usage when I come back from holiday (end of next week).

@j-f1 j-f1 changed the title Add MariaDB documentation [WIP] Add MariaDB documentation Jul 18, 2018
@jmerle jmerle changed the title [WIP] Add MariaDB documentation Add MariaDB documentation Jul 29, 2018
Switch to UrlScraper

Refactoring
@beaucarnes

beaucarnes commented Oct 18, 2018 •

Copy link
Copy Markdown
Member

@jmerle This looks good! Are you able to fix the image links? On some or all images, the original image links get modified.
For instance, in this page: http://localhost:9292/mariadb/columns-storage-engines-and-plugins/storage-engines/myrocks/about-myrocks-for-mariadb/index

The first image link is http://kb-mirror.mariadb.com/kb/en/library/documentation/columns-storage-engines-and-plugins/storage-engines/myrocks/about-myrocks-for-mariadb/+image/mariaDBstorageEngineOpt.

The link should be https://mariadb.com/kb/en/about-myrocks-for-mariadb/+image/mariaDBstorageEngineOpt

@jmerle

jmerle commented Oct 18, 2018 •

Copy link
Copy Markdown
Contributor Author

Will do that and fix the merge conflict on Saturday Sunday.

@PowerKiKi

Copy link
Copy Markdown

Is there anything left to do in order to merge this PR ?

@jmerle

jmerle commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

Nope, but it might take a while before it's merged because there are 7 open PR's older than this one and the move of the project to freeCodeCamp is not complete yet (it's getting close though).

@j-f1

j-f1 commented Jan 25, 2019 •

Copy link
Copy Markdown
Contributor

Basically, @Thibaut had almost no time to maintain this project and merge PRs like this one, so he handed it off to freeCodeCamp, which will be able to assign at least one engineer (@ahmadabdolsaheb) to work on this more often.

@ab-pivot

Copy link
Copy Markdown

Hey @Thibaut, @ahmadabdolsaheb do you have any ETA on this PR merge?

@jmerle jmerle added the docs/new label May 2, 2019
@jmerle

jmerle commented Aug 13, 2019 •

Copy link
Copy Markdown
Contributor Author

The latest commit makes the scraper scrape from https://mariadb.com/kb/en/ instead of the old https://kb-mirror.mariadb.com/ since the latter seems to have been taken down. Unfortunately the official website doesn't make it possible to distinguish between MariaDB Server documentation and the other pages in the knowledge base based on url, which is why I used a little workaround to be able to make this decision in a filter where it is possible to make the decision based on content on the page.

@jmerle
jmerle requested a review from j-f1 August 23, 2019 20:45
@j-f1

j-f1 commented Aug 24, 2019

Copy link
Copy Markdown
Contributor

For the logo, we could use a the seal logo embedded in a square image, like this one:

mariadb

@jmerle

jmerle commented Aug 28, 2019

Copy link
Copy Markdown
Contributor Author

I've added the icon you suggested, it looks good.

@jmerle

jmerle commented Oct 10, 2019

Copy link
Copy Markdown
Contributor Author

@j-f1 any chance you can check out this PR and #970? Would be nice to finally get this merged after 15 months :)

@jmerle

jmerle commented Oct 20, 2019

Copy link
Copy Markdown
Contributor Author

I believe enough time has passed for this PR and #970 to be reviewed, so I'm merging them despite not having a review approval.

jmerle added a commit to jmerle/devdocs that referenced this pull request Oct 20, 2019
@jmerle
jmerle merged commit 5ed9942 into freeCodeCamp:master Oct 20, 2019
@sbrl

sbrl commented Oct 23, 2019

Copy link
Copy Markdown

Awesome, thanks so much! :D :D :D

(btw, is it possible to write a scraper in Node at all? Contributing a scraper sounds cool, but I don't know ruby.

@jmerle

jmerle commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

No, scrapers can only be written in Ruby.

@sbrl

sbrl commented Oct 27, 2019

Copy link
Copy Markdown

That's a shame. Maybe one day I'll learn Ruby then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants