Repository navigation
Adding Official Url for url scrapped documentations - #170
Conversation
|
Thanks for your contribution. I think we should use a new attribute ( |
|
@Thibaut Thanks :) I think I've already made the box go at the top. class OfficialUrlFilter < Filter
def call
official_url_html << html if base_url
endhttps://github.com/TrangPham/devdocs/blob/master/lib/docs/filters/core/official_url.rb#L4 Should I rename |
You're right. I read the code wrong.
👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
After renaming to home_url - should I be manually adding the urls into each doc's scrapper? |
I'll add those progressively when I update each doc.
Not sure what you mean. The link should go to the project's homepage.
👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
0f420cc to
34d0d50
Compare
|
I think |
|
I'm looking through the test failures right now, and will be adding some test cases for home_url. Do you want home_url to ever be able to be blank? Since you'll be adding them in gradually? Because as I have it now, it will cause |
👍
Yes. It should be blank for all docs in this PR. |
|
@Thibaut I think this is ready for review - are there other places which I should add more tests to? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I'll merge this this week-end. |
|
@Thibaut Changes made. And thanks so much for helping me with this PR! I thought it would be easier than it was. I still don't completely understand the mechanics of how devdocs works. |
|
Didn't do much work on DevDocs this week-end. This will have to wait another week :P |
Adding Official Url for url scrapped documentations
Closes #19
This is my first attempt at this. To be honest I only have a slight understanding of what it going on here. Also the styles may need to be changed. @Thibaut Feel free to pick this apart.