Merged
Conversation
lgeiger
commented
Dec 18, 2019
| 'tf.xla' | ||
| else | ||
| node = at_css('.devsite-nav-item.devsite-nav-active') | ||
| node = node.ancestors('.devsite-nav-item').first.at_css('.devsite-nav-title') |
Contributor
Author
There was a problem hiding this comment.
Unfortunately this line breaks with the new version of the documentation, so I hard coded the top level navigation to be consistent with the TensorFlow website.
lgeiger
force-pushed
the
upgrade-tensorflow
branch
2 times, most recently
from
e3f3519 to
7737c7f
Compare
lgeiger
force-pushed
the
upgrade-tensorflow
branch
from
7737c7f to
f8b02ed
Compare
lgeiger
force-pushed
the
upgrade-tensorflow
branch
from
f8b02ed to
02e4a38
Compare
|
Could you update the status of Trello? |
Contributor
Author
@Violet-Bora-Lee Could you elaborate on what I should update in the Trello Board? I can't see any mention of it in the contributing guide. |
|
It's not mention on the guide but i think it would be better to update the status on trello to share the status among contributors :) i was trying to start tf.js dosc but i found your PR. |
Contributor
Author
|
👍 I updated the trello board |
Contributor
Author
|
@j-f1 Could you take a look this? |
Contributor
|
Thank you for contributing! |
5 tasks
Contributor
|
Small fixes in bd1644a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades TensorFlow documentation to version 2.1.
I also removed version 1.8 since it is not available on the website anymore. After this PR one could easily add support for version 2.0, 1.15 - 1.10.
Closes #1141
Closes #1010
PR Checklist
about_tmpl.coffeematches it's data inself.attributionSOURCEfile inpublic/icons/your_scraper_name/are up-to-date if the documentation has a custom iconself.linkscontains up-to-date urls ifself.linksis defined