feat: add frames.js:version meta tag to frame response - #302
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stephancill
force-pushed
the
feat/framesjs-version-metatag
branch
from
April 9, 2024 10:57
f679004 to
19806e3
Compare
stephancill
commented
Apr 9, 2024
| : {}; | ||
|
|
||
| const metadata: FrameFlattened = { | ||
| [`og:image`]: frame.ogImage || frame.image, |
Contributor
Author
There was a problem hiding this comment.
this might interfere with the generateMetadata's openGraph fields... #302
Collaborator
There was a problem hiding this comment.
Nope, there is no problem with that.
Contributor
Author
There was a problem hiding this comment.
Do you know how it behaves when other["og:image"] and openGraph["images"] is specified?
https://nextjs.org/docs/app/api-reference/functions/generate-metadata#opengraph
Collaborator
There was a problem hiding this comment.
I didn't try how it works if you use both, but it works when you supply og:image to other as well. I believe that when you do that it will overwrite the value in openGraph but I haven't tried.
In my opinion openGraph is there just to make it more convenient for developers and add some type hints.
Collaborator
There was a problem hiding this comment.
I think it should be really easy to try it locally with both and see how it works.
stephancill
force-pushed
the
feat/framesjs-version-metatag
branch
from
April 12, 2024 08:42
7c92008 to
755f129
Compare
michalkvasnicak
approved these changes
Apr 15, 2024
stephancill
added a commit
that referenced
this pull request
Apr 15, 2024
* chore: move starters to templates (#300) * chore: move utils starter completely to templates * fix: utils starter is esm module, fix config * fix: use also FARCASTER_DEVELOPER_FID env variable in debugger bin * chore: remove unused command * chore: move starter to templates * chore: changeset * chore: update docs * chore: changeset * fix: typo * chore: add readme * feat: image rendering worker (#296) * feat: images worker middleware * feat: signatures, createImagesWorker * fix: types * fix: docs typo * fix: docs dead links * fix: docs typo * fix: index exports * fix: escape user provided HTML attribute values (#306) * fix: next.js generateMetadata example code (#305) * fix: cloudflare worker template start command (#308) * fix: lock next version, move react do production dependencies (#309) * feat: add frames.js:version meta tag to frame response (#302) * feat: add frames.js:version meta tag to frame response * chore: update snapshots * fix: add og:image to required properties, matching spec * fix: type checking * fix: rebuild frames.js after version bump * feat: add a test to check parsing of html escaped characters in getFrame * fix: publish-packages script --------- Co-authored-by: Michal Kvasničák <michal.kvasnicak@gmail.com> Co-authored-by: Jereld Lim <jereldlimjy@hotmail.com>
stephancill
added a commit
that referenced
this pull request
Apr 16, 2024
* feat: add frames.js:version meta tag to frame response * chore: update snapshots * fix: add og:image to required properties, matching spec * fix: type checking * fix: rebuild frames.js after version bump * feat: add a test to check parsing of html escaped characters in getFrame * fix: publish-packages script
stephancill
added a commit
that referenced
this pull request
Apr 16, 2024
* feat: add frames.js:version meta tag to frame response * chore: update snapshots * fix: add og:image to required properties, matching spec * fix: type checking * fix: rebuild frames.js after version bump * feat: add a test to check parsing of html escaped characters in getFrame * fix: publish-packages script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
framesjs:versionmeta tag with the version in package.json to getFrameFlattenedTodo:
Merge Checklist