Skip to content

chore: move starters to templates - #300

Merged
michalkvasnicak merged 10 commits into
devfrom
chore/move-starter-to-templates
Apr 8, 2024
Merged

chore: move starters to templates#300
michalkvasnicak merged 10 commits into
devfrom
chore/move-starter-to-templates

Conversation

@michalkvasnicak

@michalkvasnicak michalkvasnicak commented Apr 8, 2024

Copy link
Copy Markdown
Collaborator

Change Summary

This PR moves starters to templates

Merge Checklist

  • PR has a Changeset
  • PR includes documentation if necessary
  • PR updates the boilerplates if necessary

@vercel

vercel Bot commented Apr 8, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frames-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 10:47am
framesjs-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 10:47am

@stephancill stephancill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically there!

would maybe be good to just put a README in the examples/framesjs-starter folder to explain that it has moved to the templates directory for those that are using the starter as a reference

Comment thread packages/frames.js/README.md Outdated
@michalkvasnicak
michalkvasnicak merged commit e564c45 into dev Apr 8, 2024
@michalkvasnicak
michalkvasnicak deleted the chore/move-starter-to-templates branch April 8, 2024 10:53
stephancill added a commit that referenced this pull request Apr 12, 2024
* chore: move starters to templates (#300)

* chore: move utils starter completely to templates

* fix: utils starter is esm module, fix config

* fix: use also FARCASTER_DEVELOPER_FID env variable in debugger bin

* chore: remove unused command

* chore: move starter to templates

* chore: changeset

* chore: update docs

* chore: changeset

* fix: typo

* chore: add readme

* feat: image rendering worker (#296)

* feat: images worker middleware

* feat: signatures, createImagesWorker

* fix: types

* fix: docs typo

* fix: docs dead links

* fix: docs typo

* fix: index exports

* fix: escape user provided HTML attribute values (#306)

* fix: next.js generateMetadata example code (#305)

---------

Co-authored-by: Michal Kvasničák <michal.kvasnicak@gmail.com>
Co-authored-by: Jereld Lim <jereldlimjy@hotmail.com>
stephancill added a commit that referenced this pull request Apr 15, 2024
* chore: move starters to templates (#300)

* chore: move utils starter completely to templates

* fix: utils starter is esm module, fix config

* fix: use also FARCASTER_DEVELOPER_FID env variable in debugger bin

* chore: remove unused command

* chore: move starter to templates

* chore: changeset

* chore: update docs

* chore: changeset

* fix: typo

* chore: add readme

* feat: image rendering worker (#296)

* feat: images worker middleware

* feat: signatures, createImagesWorker

* fix: types

* fix: docs typo

* fix: docs dead links

* fix: docs typo

* fix: index exports

* fix: escape user provided HTML attribute values (#306)

* fix: next.js generateMetadata example code (#305)

* fix: cloudflare worker template start command (#308)

* fix: lock next version, move react do production dependencies (#309)

* feat: add frames.js:version meta tag to frame response (#302)

* feat: add frames.js:version meta tag to frame response

* chore: update snapshots

* fix: add og:image to required properties, matching spec

* fix: type checking

* fix: rebuild frames.js after version bump

* feat: add a test to check parsing of html escaped characters in getFrame

* fix: publish-packages script

---------

Co-authored-by: Michal Kvasničák <michal.kvasnicak@gmail.com>
Co-authored-by: Jereld Lim <jereldlimjy@hotmail.com>
stephancill pushed a commit that referenced this pull request Apr 16, 2024
* chore: move utils starter completely to templates

* fix: utils starter is esm module, fix config

* fix: use also FARCASTER_DEVELOPER_FID env variable in debugger bin

* chore: remove unused command

* chore: move starter to templates

* chore: changeset

* chore: update docs

* chore: changeset

* fix: typo

* chore: add readme
stephancill pushed a commit that referenced this pull request Apr 16, 2024
* chore: move utils starter completely to templates

* fix: utils starter is esm module, fix config

* fix: use also FARCASTER_DEVELOPER_FID env variable in debugger bin

* chore: remove unused command

* chore: move starter to templates

* chore: changeset

* chore: update docs

* chore: changeset

* fix: typo

* chore: add readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants