feat(lint): add assert-state-change#14784
Open
mablr wants to merge 1 commit into
Open
Conversation
Detects state-modifying expressions inside `assert()` calls.
mablr
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mattsse,
stevencartavia and
zerosnacks
as code owners
mattsse
requested changes
May 16, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
One remaining behavior gap before this lands.
| find_state_change(hir, inner) | ||
| } | ||
|
|
||
| ExprKind::Call(callee, args, named_args) => { |
Member
There was a problem hiding this comment.
This only treats push/pop and bare identifier functions as mutating calls. External/member calls inside assert, e.g. assert(this.deposit()), assert(payable(to).send(1 ether)), or a token/interface call with side effects, fall through to recursion and are not reported. Since the lint is documented as catching function calls that write state, can we either detect mutating external/member calls or narrow the docs/tests to the intended scope?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add
assert-state-changelint to detect state-modifying expressions insideassert()arguments.PR Checklist