Skip to content

Conversation

@ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

N/A

Description

What changed?

Changed the tests so that each it block calls done once. This makes sure that done is not called prematurely

Why have you chosen this solution?

Get rid of flaky tests

Breaking Changes / Backwards Compatibility

N/A

Dependencies

N/A

How has this PR been tested?

By changing the tests and running them to see if they pass

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants