Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Percent-encode parentheses in
filename*Content-Disposition header values per RFC 5987.Problem
Parentheses
(and)are separator characters per RFC 2616 and must be percent-encoded infilename*values per RFC 5987. Currently they are passed through unencoded, causing .NET backends (and other strict HTTP parsers) to reject the multipart request.Solution
Add parentheses to the set of characters that are percent-encoded when generating
filename*values. When a filename contains characters outside the RFC 5987attr-charset, afilename*parameter with proper percent-encoding is emitted alongside the existingfilenameparameter for backward compatibility.Test Plan
test(1).txtproducesfilename*=utf-8''test%281%29.txttest.txt) do not get afilename*parametermy file.txt→my%20file.txt)filename(non-starred) headerFixes #572