Skip to content

Fix constructor options in Typescript definitions - #446

Merged
mapleeit merged 2 commits into
form-data:masterfrom
Ovyerus:fix-constructor-type
Oct 29, 2019
Merged

mapleeit merged 2 commits into
form-data:masterfrom
Ovyerus:fix-constructor-type

Conversation

@Ovyerus

@Ovyerus Ovyerus commented Oct 19, 2019 •

Copy link
Copy Markdown
Contributor

Adds definitions for the options of stream.Readable with the options definitions for FormData.
Also passes options through to the constructor if FormData is called without new.

Fixes #443

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 98.122% when pulling 4bde68e on Ovyerus:fix-constructor-type into 06568ed on form-data:master.

@mapleeit mapleeit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapleeit
mapleeit merged commit cd27e9a into form-data:master Oct 29, 2019
@mapleeit mapleeit mentioned this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

types for constructor are incomplete

3 participants