Skip to content

- Added: public methods with information and examples to readme - #429

Merged
alexindigo merged 5 commits into
form-data:masterfrom
JBtje:master
Jul 3, 2019
Merged

alexindigo merged 5 commits into
form-data:masterfrom
JBtje:master

Conversation

@JBtje

@JBtje JBtje commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@JBtje

JBtje commented Jun 24, 2019

Copy link
Copy Markdown
Contributor Author

@mapleeit @alexindigo First draft. I think there are a few other points in the readme that could use a bit more information. Please let me know if this is the right direction, and if the information I typed is correct. I have not yet tested the sample code... so please don't merge :)

@coveralls

coveralls commented Jun 24, 2019 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 98.122% when pulling d88f912 on JBtje:master into ae2b25d on form-data:master.

Comment thread Readme.md Outdated
@alexindigo

Copy link
Copy Markdown
Member

@JBtje Please rebase, windows tests should be stable now.
Thank you.

@alexindigo
alexindigo merged commit 423c32d into form-data:master Jul 3, 2019
@mapleeit

mapleeit commented Jul 3, 2019

Copy link
Copy Markdown
Collaborator

Hi, @alexindigo can we make a release? 😃
Waiting for making PR to remove types of DefinitelyTyped. (I'm afraid of forgetting it in a while)

@alexindigo

Copy link
Copy Markdown
Member

@mapleeit Published 2.5.0. Thanks for driving it forward.

@mapleeit

mapleeit commented Jul 4, 2019

Copy link
Copy Markdown
Collaborator

👍 And I'm removing @types/form-data from DefinitelyTyped now.

DefinitelyTyped/DefinitelyTyped#36644

@alexindigo

Copy link
Copy Markdown
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants