Repository navigation
Added "getBuffer" method and updated certificates - #419
Conversation
Added method: getBuffer() Added Test: to test GetBuffer()
JBtje
changed the title
|
Great work. Please take a look at this! @alexindigo BTW. It seems CI was broken. #424 only change some docs, but it failed anyway. |
| 099h1IJLtsPJVphSDBTtE0FLB0YIzT7bG44Drm/975XEZjoQ9TmYbTMCAwEAATAN | ||
| BgkqhkiG9w0BAQUFAANBALSDmvKXb4cE622OdSRrDsnr8xUosetsAGSlGauWBKgc | ||
| DNQhP6wSQHTAJT8wiVgSPYwnhcnzkZlwzdfMHMtzFIc= | ||
| MIIFfzCCA2egAwIBAgIJALeHtgIY/UKcMA0GCSqGSIb3DQEBCwUAMFUxCzAJBgNV |
There was a problem hiding this comment.
Why would we need to change test certs?
There was a problem hiding this comment.
With the installed certificate, I was unable to run all the tests: the certificate format was outdated (if i recall correctly). So I added a new one, all tests succeeded and pushed.
There was a problem hiding this comment.
Thanks. I restarted windows builds 🤞
|
It is an honour to have contributed to such an important project. Many thanks for merging! |
|
@JBtje Thanks for your help and pushing it forward. I'll publish your change shortly. |
|
Published as part of |
|
Good to know that. Thanks! |
|
In addition, I'm wondering is there any document for all APIs? I couldn't find that in README or anywhere else. If YES, we should add this to the document. |
|
I don't think there is... I realised it yesterday that my merge req. didn't have documentation update. But havent had the time to make a proper one and submit it. Will see if I can do that upcomming weekend. |
|
Sounds great. If you need any help, please contact me. : ) |
|
Thank you for doing it @mapleeit |
form-data works with many packages, however it does not work out of the box with Axios. Many times the question has been asked as to how to make it work, but no proper solution is provided. I think it would be nice if form-data allows users to obtain the datapackage (as buffer) so they can do with it whatever they like, e.g. pass it over to Axios.
Added method: getBuffer()
Added Test: to test GetBuffer()
Updated: Certificates where signed with small key and needed replacement to make the test pass.