return request from .submit() #47

Activity

1. felixge commented on Aug 20, 2013

   

   felixge

   on Aug 20, 2013

   Contributor

   More actions

   Hm, seems like the request object needs the Content-Length in order be constructed. Since getting the value for that is async it can't be returned right away. Got an idea for a patch?
2. alexindigo commented on Aug 20, 2013

   

   alexindigo

   on Aug 20, 2013

   Member

   More actions

   We can create request object before async call and return it and populate it later. But I was thinking that it's might be confusing to return httpRequest from FormData, since people might expect it to be same object.
   Maybe we'll be better off just translating events.

   @visionmedia How are you going track the progress on httpRequest?
3. tj commented on Aug 20, 2013

   

   tj

   on Aug 20, 2013

   Author

   More actions

   unfortunate we can't initialize a node request to return (that I know of at least), emitting an event would be pretty weird, two callbacks is weird. I just wrote submit() with the progress stuff built in but im not sure what would be best in here. hmm yeah aside from an event or second callback I'm not sure
4. tj commented on Aug 20, 2013

   

   tj

   on Aug 20, 2013

   Author

   More actions

   @alexindigo I'm just proxying the .write() to the request with this hack:

       var write = req.write;
       req.write = function(chunk){
         return write.call(this, chunk, function(){
           form.emit('progress', chunk, len);
         });
       };

   and later using that to do the actual progress reporting. Maybe if we make that stuff into a little module and just do trackProgress(req).on('progress', re-emit crap here) we could add it to form-data :s haha, but no point turning it into another request library
5. alexindigo commented on Aug 20, 2013

   

   alexindigo

   on Aug 20, 2013

   Member

   More actions

   How about?

   if (params.request) {
     request = params.request;
   } else {
     // https if specified, fallback to http in any other case
     if (params.protocol == 'https:') {
       // override default port
       if (!params.port) options.port = 443;
       request = https.request;
     } else {
       request = http.request;
     }
   }
   
   request = request(options);

   then you can have your own augmented request instantiation function.
6. alexindigo commented on Aug 20, 2013

   

   alexindigo

   on Aug 20, 2013

   Member

   More actions

   Oh, looks like we still can add content-length later:

   "The header is still mutable using the setHeader(name, value), getHeader(name), removeHeader(name) API. The actual header will be sent along with the first data chunk or when closing the connection."

   But, again, don't you think it will be confusing to return httpRequest from FormData.submit?
7. tj commented on Aug 21, 2013

   

   tj

   on Aug 21, 2013

   Author

   More actions

   I think returning it is the most sensible thing personally, especially since it wont break anyone's apps since it's not returning this for chaining
8. alexindigo

   added a commit that references this issue on Aug 21, 2013

   form-data#47 return request from .submit()

   1d61c2d
9. alexindigo commented on Aug 21, 2013

   

   alexindigo

   on Aug 21, 2013

   Member

   More actions

   @visionmedia @felixge Something like that.
10. alexindigo

    added 2 commits that reference this issue on Aug 22, 2013

    form-data#47 Updated readme.

    e3dae15

    Merge pull request #48 from alexindigo/master

    ...

    ab18129
11. alexindigo

    closed this as completedon Aug 22, 2013