Using enum in switch case

mzitnik · mzitnik · commit 2eff5cf0d5d2 · 2023-05-15T10:38:35.000+03:00
diff --git a/clickhouse-http-client/src/main/java/com/clickhouse/client/http/HttpUrlConnectionImpl.java b/clickhouse-http-client/src/main/java/com/clickhouse/client/http/HttpUrlConnectionImpl.java
@@ -108,8 +108,8 @@ private HttpURLConnection dispatchProxy(ClickHouseProxyType proxyType) throws IO
         HttpURLConnection newConn = null;
         ClickHouseConfig c = config;
 
-        switch (proxyType.toString()) {
-            case "HTTP":
+        switch (proxyType) {
+            case HTTP:
                 if ( c.getProxyHostName() == "" || c.getProxyPort() == -1 ) {
                     log.error("config for HTTP proxy is invalid hostname [%s] port [%d]", c.getProxyHostName(), c.getProxyPort());
                     throw new RuntimeException(String.format("config for HTTP proxy is invalid hostname [%s] port [%d]", c.getProxyHostName(), c.getProxyPort()));
@@ -118,10 +118,10 @@ private HttpURLConnection dispatchProxy(ClickHouseProxyType proxyType) throws IO
                         = new Proxy(Proxy.Type.HTTP, new InetSocketAddress(c.getProxyHostName(), c.getProxyPort()));
                 newConn = (HttpURLConnection) new URL(url).openConnection(webProxy);
                 break;
-            case "DIRECT":
+            case DIRECT:
                 newConn = (HttpURLConnection) new URL(url).openConnection(Proxy.NO_PROXY);
                 break;
-            case "SOCKS":
+            case SOCKS:
                 if ( c.getProxyHostName() == "" || c.getProxyPort() == -1 ) {
                     log.error("config for HTTP proxy is invalid hostname [%s] port [%d]", c.getProxyHostName(), c.getProxyPort());
                     throw new RuntimeException(String.format("config for HTTP proxy is invalid hostname [%s] port [%d]", c.getProxyHostName(), c.getProxyPort()));
