Conversation
thomasfr
left a comment
There was a problem hiding this comment.
While this definitely makes handling the language parameter in the code much easier, it also completely prevents the easy and cheap use of edge caching for HTML pages, with Cloudflare. Currently, you can safely cache everything on CF with a "Cache Rule" because a given URL always returns the same response for all website visitors. However, mixing query parameters and cookie values for the language parameter prevents automatic HTML edge caching through a "Cache Rule." Only with the Cloudflare Business Plan ($200/month/domain) can you use cookie values as part of the cache key.
I suggest not changing this for now, perhaps we can find a better solution that addresses both scenarios or document alternative approaches and their implications.
Fixes #
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
Screenshots (if appropriate):
Questions (if appropriate):