Repository navigation
Conversation
`value_unref_type`, `forward_ref`, `forward_lvalue_ref` and `unwrap_ref_or_forward` move into functional/ref_unwrapping.h, together with the `<utility>`/`<functional>` include they need; their users include it. Co-Authored-By: Claude Opus 5
…mments - Groups under accurate headings: generic type traits (`is_any_of`, `is_eval_order_guaranteed`, `stateless`), type computations over packs (`common_type_of`, `same_or_void`), SFINAE helpers and type name projectors. - Removes `match_specialization_of` and `satisfies_is_specialization_of`; the one use of the former in column_result_proxy.h tests `polyfill::is_specialization_of_v` directly. - Fixes the spelling of `is_eval_order_guaranteed`, and "guaranteed" in sqlite3_xdestroy.h. - The ref_unwrapping.h comments state what each entity is; the one of `value_unref_type` no longer claims a `remove_cvref` it does not apply. Co-Authored-By: Claude Opus 5
Like `common_type_of` and `same_or_void`, `is_any_of` computes over a pack of types rather than classifying a single type. Co-Authored-By: Claude Opus 5
The common argument type was computed by wrapping the resolved types into a `std::tuple` only for `common_type_of` to unpack them again. Co-Authored-By: Claude Opus 5
…l-type-traits # Conflicts: # dev/marshaling/column_result_proxy.h # include/sqlite_orm/sqlite_orm.h
`polyfill::is_specialization_of` takes a template template parameter, so it cannot be passed to `match_if`/`satisfies`; the two helpers complete the SFINAE helpers for it. column_result_proxy.h uses `match_specialization_of` again. Co-Authored-By: Claude Opus 5
Each SFINAE helper for functions mirrors the name of its counterpart for types: `match_if`/`satisfies`, `match_if_not`/`satisfies_not`, `match_specialization_of`/`satisfies_specialization_of`. Co-Authored-By: Claude Opus 5
ref_unwrapping.h includes `<utility>` for `std::forward` and `std::declval` unconditionally rather than only in the C++20 branch for `std::reference_wrapper`. The include comments of type_traits.h and accessors.h name what is used. Co-Authored-By: Claude Opus 5
…erence `<utility>` is included unconditionally now, so the C++20 branch of the conditional was redundant. Co-Authored-By: Claude Opus 5
…wrapper Co-Authored-By: Claude Opus 5
trueqbit
marked this pull request as ready for review
October 24, 2026 20:28
…plate `Template` names any class template, as in `check_if_is_template` and `find_tuple_template`. Co-Authored-By: Claude Opus 5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1603.
functional/type_traits.hfiled astd::reference_wrapperunwrapping facility, including functions, under "C++ generic traits", and its other groups only partly matched their headings.value_unref_type,forward_ref,forward_lvalue_refandunwrap_ref_or_forwardmove tofunctional/ref_unwrapping.h(pure move, its own commit); their users include it. Their comments are condensed to what each entity is, and the one ofvalue_unref_typeno longer claims aremove_cvrefthe trait does not apply.type_traits.his grouped as generic type traits (is_eval_order_guaranteed,stateless), type algorithms over packs (is_any_of,common_type_of,same_or_void), SFINAE helpers and type name projectors.satisfies_is_specialization_ofis renamed tosatisfies_specialization_of, so that each SFINAE helper for functions mirrors its counterpart for types (match_if/satisfies,match_if_not/satisfies_not,match_specialization_of/satisfies_specialization_of).argument_placeholders.husesstd::common_typedirectly instead of wrapping the resolved types into astd::tupleforcommon_type_ofto unpack.is_eval_order_garanteedis renamed tois_eval_order_guaranteed, and "garanteed" is corrected in two comments ofsqlite3_xdestroy.h.All of it is internal; consumers observe no change.
🤖 Generated with Claude Code