Repository navigation
Conversation
Converts the internal uses in builtin_function.h, column_result.h, db_objects.h and virtual_table.h, which now include mpl/conditional.h, and drops std::conditional from the include comments that no longer use it. The public builtin functions in builtin/functions/core.h keep std::conditional_t, which their declared return types show in diagnostics. Co-Authored-By: Claude Opus 5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1602.
mpl::conditional_tmemoizes only two class template instances (mpl::conditional<true>andmpl::conditional<false>) and selects through a nested alias template, whereas eachstd::conditional_tuse instantiates astd::conditionalspecialization for its argument triple.ast/builtin_function.h,result_set/column_result.h,schema/db_objects.handschema/virtual_table.hswitch tompl::conditional_t; these headers now includempl/conditional.h.std::conditionalwhere it is not used anymore (alsotuple_filter.h, which had already switched).builtin/functions/core.hkeepstd::conditional_t: it appears in their declared return types and thus in consumer diagnostics, and the memoization gain there is negligible.🤖 Generated with Claude Code